Fix invalid query string for array params #1908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Yeah, this makes sense for them to be encoded. The answer on this stackoverflow says that square brackets can appear in the host, but should be percent encoded in the query string. Looks like there's some weird failures going on. I don't think they're related to this PR. At least for sure not the exception page, but can you look at the cookie stuff? If it's unrelated, then we can fix that separately. Thanks for taking this on! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #1880
Duplicate of #1907
Description
In #1907, I assumed the square brackets (
[]) in array query params should not be encoded. I believe it should, and this PR addresses that. If accepted, #1907 should be rejected.Checklist
crystal tool format spec src./script/setup./script/test